Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish SPM #7

Merged
merged 17 commits into from
May 8, 2024
Merged

Publish SPM #7

merged 17 commits into from
May 8, 2024

Conversation

eirikvaa
Copy link
Member

@eirikvaa eirikvaa commented May 3, 2024 •
edited
Loading

  • Clean up this PR before marking it ready for review.

@eirikvaa eirikvaa self-assigned this May 3, 2024
@eirikvaa eirikvaa requested review from airxnoor and LaStrada May 3, 2024 06:40
airxnoor
airxnoor reviewed May 3, 2024
View reviewed changes
build.gradle.kts Outdated Show resolved Hide resolved
airxnoor
airxnoor reviewed May 3, 2024
View reviewed changes
build.gradle.kts Outdated Show resolved Hide resolved
airxnoor
airxnoor reviewed May 3, 2024
View reviewed changes
gradle.properties Outdated Show resolved Hide resolved
@eirikvaa eirikvaa changed the title Publish spm Publish SPM May 3, 2024
@airxnoor airxnoor marked this pull request as ready for review May 8, 2024 09:44
@airxnoor airxnoor self-requested a review May 8, 2024 09:44
@eirikvaa
Copy link
Member Author

eirikvaa commented May 8, 2024

@airxnoor You have to approve, I cannot since I made the PR 😆

airxnoor
airxnoor approved these changes May 8, 2024
View reviewed changes
Copy link
Collaborator

@airxnoor airxnoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Eirik is the author, I must approve it even though I added a bunch of new features :) Bottom line, great work started by Eirik! 🎉

I'd love if @LaStrada could take a look too and check it out.

@airxnoor @LaStrada
Update .github/actions/java/action.yml
94a171e 
Co-authored-by: Ståle Storø Hauknes <[email protected]>
LaStrada
LaStrada approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@LaStrada LaStrada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🚀

@eirikvaa eirikvaa merged commit 25f1b33 into main May 8, 2024
2 checks passed
@eirikvaa eirikvaa deleted the publish-spm branch May 8, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airxnoor airxnoor airxnoor approved these changes

@LaStrada LaStrada LaStrada approved these changes

Assignees

@eirikvaa eirikvaa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eirikvaa @LaStrada @airxnoor